Fix prepare step causing false github warnings #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenh
changed the title
stephenh
commented
Jun 7, 2020
| @@ -11,7 +11,7 @@ jobs: | |||
| - v1-dependencies-{{ checksum "package.json" }} | |||
| - v1-dependencies- | |||
|
|
|||
| - run: yarn install || echo "ignore failure" | |||
| - run: yarn install | |||
There was a problem hiding this comment.
@cliedeman fwiw this is where those false-positive failures were coming from; the github actions was picking up the stdout/stderr from this yarn install running prepare which was doing a yarn build "before we really wanted".
I was trying to use prepare as a "before publish" but not "after install", which looks like is not possible? So just taking out prepare for now and will use a more manual ./publish.sh.
There was a problem hiding this comment.
Ah super weird. Did not know it did that.
prepublishOnly might do what you want
There was a problem hiding this comment.
Ah I think so, thanks for pointing out prepublishOnly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.