pin version in testing

span names changed open-telemetry/opentelemetry-python-contrib#1757
stephenc-pace · Sep 25, 2023 · 866fbb1 · 866fbb1
1 parent c1131a3
commit 866fbb1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/setup.py b/setup.py
@@ -38,7 +38,7 @@
             "coverage",
             "pytest",
             "opentelemetry-sdk",
-            "opentelemetry-instrumentation-requests",
+            "opentelemetry-instrumentation-requests>=0.39b0",
         ],
         "instruments": PACKAGE_INFO["_instruments"],
     },

diff --git a/tests/test_http.py b/tests/test_http.py
@@ -89,7 +89,7 @@ def test_no_match(self, container, web_session, memory_exporter):
         spans = memory_exporter.get_finished_spans()
         assert len(spans) == 1
 
-        assert spans[0].name == "HTTP GET"
+        assert spans[0].name == "GET /missing"
 
 
 class TestNoEntrypointFired:
@@ -121,7 +121,7 @@ def test_method_not_found(self, container, web_session, memory_exporter):
 
         span = spans[0]
 
-        assert spans[0].name == "HTTP GET"
+        assert spans[0].name == "GET /missing"
 
         assert not span.status.is_ok
         assert span.status.status_code == StatusCode.ERROR
@@ -139,7 +139,7 @@ def test_method_not_allowed(self, container, web_session, memory_exporter):
 
         span = spans[0]
 
-        assert spans[0].name == "HTTP POST"
+        assert spans[0].name == "POST /resource"
 
         assert not span.status.is_ok
         assert span.status.status_code == StatusCode.ERROR