forked from temporalio/temporal
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
OTEL annotates gRPC responses (temporalio#7165)
## What changed? <!-- Describe what has changed in this PR --> Added support for our OTEL interceptor to parse tags from the gRPC response (not just the request). ## Why? <!-- Tell your future self why have you made these changes --> Without annotating the responses, traces from calls like `PollWorkflowTaskQueue` cannot be queried for since the ID is only on the response but not the request. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Verified in Tempo: <img width="1573" alt="image" src="https://github.com/user-attachments/assets/96a1f1b3-99f5-48f4-b603-b0b66f158538" /> ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> There is one other caller of `Extract`, but they are only feeding in the request payload. So no behavior change is expected. ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
- Loading branch information
Showing
7 changed files
with
556 additions
and
71 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88 changes: 86 additions & 2 deletions
88
common/rpc/interceptor/logtags/admin_service_server_gen.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.