Use a combined cache derivation by default #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephank
force-pushed
the
feat/combined-drv
branch
4 times, most recently
from
6c4b76c
to
52e8c7a
Compare
`yarn pack` already logs a file listing.
stephank
force-pushed
the
feat/combined-drv
branch
from
52e8c7a
to
799d16b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to generate a single derivation for the entire cache directory (as opposed to individual derivations per dependency), and makes it the new default behavior.
The individual packaging has bothered me for quite a bit, because while it allows granular caching, I've found it is terribly slow in many cases. When there is no cache or preload, each derivation that has to be built takes seconds, because it has to invoke Node.js and load all of Yarn.
The generated
yarn-project.nixis also a lot simpler, because there is just one hash now. It works a bit more likebuildGoModuleorbuildRustPackage, in that sense.