This repository was archived by the owner on Mar 30, 2026. It is now read-only.
refactor: merge deps into hooks provisioning pipeline#176
Merged
Conversation
Eliminate the parallel deps pipeline (phase_deps_root + phase_deps_post) by merging dep scripts into postProvisionHooks with runAs metadata. This gives one execution path for all custom provisioning scripts. - Give brave-search a real postInstallScript instead of hardcoded special case in provisioner-config.ts - Add optional runAs field to hook entries (defaults to "ubuntu" in the bash template via jq) - Prepend dep scripts to postProvisionHooks as dep:<name>:install (runAs: root) and dep:<name>:post (runAs: ubuntu) - Remove phase_deps_root/phase_deps_post from bash template - Clean up dead braveApiKey/tools fields from config-generator.ts - Update tests to verify new hook structure and ordering Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... 📒 Files selected for processing (5)
✏️ Tip: You can disable in-progress messages and the fortune message in your review settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
phase_deps_root+phase_deps_post) by merging dep scripts intopostProvisionHookswithrunAsmetadatapostInstallScriptinstead of a hardcoded special case inprovisioner-config.tsrunAsfield to hook entries, defaulting to"ubuntu"in the bash templatebraveApiKey/toolsfields fromconfig-generator.tsTest plan
pnpm build— all packages compilepnpm test— all 344 tests passphase_deps_root/phase_deps_postpostProvisionHookscontainsdep:*entries with correctrunAsconfigSetCommands🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
runAsfield to provisioning hooks for per-hook user execution control (root or ubuntu).Improvements