Repository navigation
feat: Onboard benchmark-action/github-action-benchmark action - #1
Conversation
4437db5 to
a87fc8a
Compare
|
placeholder review comment - will be replaced |
PR Review\n\n### Action Type\nNode-based action - runs on node24, entry point at dist/src/index.js.\n\n### Passed Checks\n- License: Present with dual copyright (StepSecurity 2026 and original author rhysd 2019)\n- action.yml: Present with author step-security\n- SECURITY.md: Present\n- FUNDING.yml: Not present\n- auto_cherry_pick.yml and actions_release.yml: Both present\n- renovate.json: Not present\n- PULL_REQUEST.md: Not present\n- ISSUE_TEMPLATE folder: Not present\n- CHANGELOG.md: Not present\n- .vscode folder: Not present\n- README.md banner: StepSecurity banner present at top\n- README.md semver: All examples use @v1 major-version-only tags\n- Subscription check URL: Correct endpoint used\n- Upstream variable: benchmark-action/github-action-benchmark matches auto_cherry_pick.yml\n- package.json author: step-security\n- package.json repository: Contains step-security\n- dist folder: Present at dist/src/index.js\n- Build script: Present in package.json\n- Dependencies: All runtime deps (axios, zod, @actions/*) actively used\n\n### Failed Checks\nNone.\n\n### Warnings\n- alert-comment-cc-users validation is too permissive: only checks for @ prefix, no newline/special-char restriction - markdown injection possible (inline comment on src/config.ts)\n- Token embedded in raw Error.message in src/git.ts: core.setSecret() masks it in Actions logs but Error.message is unsanitized (inline comment on src/git.ts)\n- git push --no-verify: pre-push hooks skipped, intentional but worth documenting\n\n### Security Findings\n1. Token leak risk in error messages (src/git.ts:71): cmd() joins git args including the token-bearing remote URL into error message strings. core.setSecret() masks it in Actions log sinks but not in raw Error.message. Inline suggestion posted.\n2. Markdown injection via alert-comment-cc-users (src/config.ts:169-174): Only @ prefix check enforced; newlines allow injecting arbitrary markdown into comments. Inline suggestion posted.\n\n### Summary\nOnboarding is structurally complete - all required files present, subscription check correctly wired, upstream attribution matches, README and action metadata reference step-security correctly. Two security hardening items (token redaction in error messages and stricter username validation) should be addressed before merging. |
Signed-off-by: Anurag Rajawat <anurag@stepsecurity.io>
a87fc8a to
533b4e1
Compare
PR ReviewAction TypeNode-based action — uses Passed Checks
Failed ChecksNo hard-failing checklist items were found. Warnings
Security Findings
SummaryThe PR successfully onboards the upstream |
…and update README references
https://github.com/benchmark-action/github-action-benchmark