-
Notifications
You must be signed in to change notification settings - Fork 15
Add a helper to user generators as PHPUnit data providers #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
krtek4
wants to merge
3
commits into
steos:master
Choose a base branch
from
krtek4:dataprovider
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| <?php | ||
|
|
||
| namespace QCheck; | ||
|
|
||
| /** | ||
| * This class serves as a helper to create data providers | ||
| * for PHPUnit based testing. | ||
| * | ||
| * @package QCheck | ||
| */ | ||
| class DataProvider { | ||
| /** | ||
| * Transform an array of generators to an array of data that | ||
| * can be used for PHPUnit test methods. | ||
| * | ||
| * @param Generator[] $generators | ||
| * @param int $n number of data sets to generate. | ||
| * @return array | ||
| */ | ||
| public function provider(array $generators, $n = 100) { | ||
| $tuples = call_user_func_array('QCheck\Generator::tuples', $generators); | ||
| return $tuples->takeSamples($n); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| <?php | ||
|
|
||
| namespace QCheck; | ||
|
|
||
| class DataProviderTest extends \PHPUnit_Framework_TestCase { | ||
| function provider($name, $n = 10) { | ||
| return DataProvider::provider(array( | ||
| Generator::strings(), | ||
| Generator::ints(), | ||
| Generator::booleans() | ||
| ), $n); | ||
| } | ||
|
|
||
| /** | ||
| * @dataProvider provider | ||
| */ | ||
| function testDataProvider($s, $i, $b) { | ||
| // this test is only supposed to prove that we have a valid provider | ||
| $this->assertTrue(is_string($s)); | ||
| $this->assertTrue(is_int($i)); | ||
| $this->assertTrue(is_bool($b)); | ||
| } | ||
|
|
||
| function testDataProviderCount() { | ||
| $numbers = array(1, 10, 50); | ||
|
|
||
| foreach($numbers as $n) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Using |
||
| $data = $this->provider('testDataProviderCount', $n); | ||
| $this->assertCount($n, $data); | ||
| $this->assertCount(3, $data[0]); | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
$this->assertInternalType('string', $s);is preferred over usingassertTrue