Skip to content

refactor: convert magrittr %>% to base |> and ensure RHS calls use pa… #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stemangiola wants to merge 18 commits into
base: master
Choose a base branch
from
Open

refactor: convert magrittr %>% to base |> and ensure RHS calls use pa… #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
7e58cb6
refactor: convert magrittr %>% to base |> and ensure RHS calls use pa…
stemangiola Oct 25, 2025
77d148c
fix the pipe conversion
stemangiola Oct 25, 2025
dd21e31
Convert magrittr pipes to base R pipes
stemangiola Oct 25, 2025
329d8ba
Fix annotation_group examples to prevent CI/CD failures
stemangiola Oct 25, 2025
b8a85f1
Fix discarded pipe result in utilities.R
stemangiola Oct 25, 2025
dec654e
Refactor color mapping and data filtering logic
cursoragent Oct 25, 2025
35fa91b
Fix remaining when() calls and break pipe chains with if statements
stemangiola Oct 25, 2025
84cd62c
Fix all remaining when() calls and break pipe chains
stemangiola Oct 25, 2025
dcf750c
Use case_when() for cleaner conditional logic
stemangiola Oct 25, 2025
35a95ca
Fix as_matrix function to work with base R pipes
stemangiola Oct 25, 2025
ecd283d
Fix validation function parameter names for base R pipes
stemangiola Oct 25, 2025
02ced51
Fix logical condition in subset function for column validation
stemangiola Oct 25, 2025
4f65dc4
Fix %in% operator precedence issues with base R pipes
stemangiola Oct 25, 2025
41829e8
refactor: drop ifelse_pipe/ifelse2_pipe; simplify conditionals; fix t…
stemangiola Oct 28, 2025
ae5ba5b
Bump version from 1.12.3 to 1.12.4
stemangiola Oct 28, 2025
d4bb468
Update DESCRIPTION
stemangiola Oct 28, 2025
632259b
Merge branch 'master' into chore/convert-to-base-pipe
stemangiola Oct 28, 2025
6115d9a
fix: vignette build by normalizing annotation arg merging and list ha…
stemangiola Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,13 @@ sccomp_draws_files
.git/
# Vignette build artifacts
vignettes/*.html
vignettes/*_files/
# Documentation build artifacts
inst/doc/
doc/*.html
# R CMD check artifacts
..Rcheck/
.Rcheck/
# Temporary files
*.tmp
*.temp
Expand Down
3 changes: 3 additions & 0 deletions CRAN-SUBMISSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Version: 1.13.0
Date: 2025-10-27 23:45:40 UTC
SHA: e075db2b1143c115e2292d8ae117b3efc8e27cfd
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Type: Package
Package: tidyHeatmap
Title: A Tidy Implementation of Heatmap
Version: 1.13.0
Version: 1.13.1
Authors@R:
c(person(given = "Stefano",
family = "Mangiola",
Expand Down
4 changes: 2 additions & 2 deletions NAMESPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ export(annotation_numeric)
export(annotation_point)
export(annotation_tile)
export(as_ComplexHeatmap)
export(colorRamp2)
export(get_heatmap_data)
export(heatmap)
export(layer_arrow_down)
Expand All @@ -22,6 +23,7 @@ export(save_pdf)
export(scale_robust)
export(split_columns)
export(split_rows)
export(unit)
export(wrap_heatmap)
exportMethods(annotation_group)
exportMethods(as_ComplexHeatmap)
Expand Down Expand Up @@ -56,13 +58,11 @@ importFrom(grid,unit.c)
importFrom(lifecycle,deprecate_warn)
importFrom(lifecycle,is_present)
importFrom(magrittr,"%$%")
importFrom(magrittr,"%>%")
importFrom(magrittr,equals)
importFrom(magrittr,set_rownames)
importFrom(methods,new)
importFrom(methods,show)
importFrom(patchwork,wrap_elements)
importFrom(purrr,as_mapper)
importFrom(purrr,map)
importFrom(purrr,map2)
importFrom(purrr,map_chr)
Expand Down
Loading
Loading