Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update metadata function to allow interacting multiple databases #130

Closed
wants to merge 13 commits into from

Conversation

myushen
Copy link
Contributor

@myushen myushen commented Feb 21, 2024

No description provided.

R/metadata.R Outdated Show resolved Hide resolved
R/metadata.R Outdated Show resolved Hide resolved
R/utils.R Outdated Show resolved Hide resolved
R/metadata.R Outdated Show resolved Hide resolved
R/metadata.R Outdated Show resolved Hide resolved
Copy link
Collaborator

@multimeric multimeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to:

  • Update the vignettes
  • Update the documentation for get_metadata() to explain how remote_url has changed

tests/testthat/test-query.R Outdated Show resolved Hide resolved
tests/testthat/test-query.R Outdated Show resolved Hide resolved
R/metadata.R Outdated Show resolved Hide resolved
R/metadata.R Outdated Show resolved Hide resolved
R/metadata.R Outdated Show resolved Hide resolved
R/utils.R Show resolved Hide resolved
R/counts.R Show resolved Hide resolved
@stemangiola
Copy link
Owner

stemangiola commented Feb 22, 2024

Congrats @myushen ! First PR done! @multimeric I leave to you the merge authority.

@myushen myushen closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants