add present operator, update test data

stelligent · Mar 7, 2018 · 67e7a17 · 67e7a17
1 parent ef7550e
commit 67e7a17
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/app.go b/app.go
@@ -113,7 +113,7 @@ func unquoted(s string) string {
 func isValid(searchResult, op, value, severity string) string {
 	// TODO see Cloud Custodian for ideas
 	// ADD gt, ge, lt, le
-	// absent, present, not-null, empty
+	// absent, not-null, empty
 	// and, or, not, intersect
 	// glob
 	switch op {
@@ -138,6 +138,10 @@ func isValid(searchResult, op, value, severity string) string {
 			}
 		}
 		return "OK"
+	case "present":
+		if searchResult != "null" {
+			return "OK"
+		}
 	case "regex":
 		if regexp.MustCompile(value).MatchString(unquoted(searchResult)) {
 			return "OK"

diff --git a/files/terraform.hcl b/files/terraform.hcl
@@ -1,12 +1,16 @@
 resource "aws_instance" "first" {
 	ami = "ami-f2d3638a"
 	instance_type = "t2.micro"
+    tags {
+        "CostCenter" = "1001"
+    }
 }
 resource "aws_instance" "second" {
 	ami = "ami-f2d3638a"
 	instance_type = "m3.medium"
 	tags {
 		Department = "Operations"
+        CostCenter = "2001"
 	}
 }
 resource "aws_instance" "third" {

diff --git a/rules/terraform.yml b/rules/terraform.yml
@@ -44,3 +44,11 @@ Rules:
         op: regex
         value: ".com$"
     severity: WARNING
+  - id: R6
+    message: CostCenter tag is missing
+    resource: aws_instance
+    filters:
+      - type: value
+        key: "tags[].CostCenter | [0]"
+        op: present
+    severity: FAILURE