Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scan): add rule directory recursive #596

Merged
merged 1 commit into from
May 17, 2022

Conversation

dclayton-godaddy
Copy link
Contributor

Add the ability to lookup rules in subdirectories when using --rule-directory ./rules --rule-directory-recursive.

Parameter --rule-directory-recursive should include IAMNameRule.rb and GeneralRule.rb.

rules/
    IAM/
        IAMNameRule.rb
    GeneralRule.rb

closes #595

@dclayton-godaddy dclayton-godaddy marked this pull request as ready for review May 6, 2022 20:16
@dclayton-godaddy dclayton-godaddy requested a review from a team as a code owner May 6, 2022 20:16
@dsilbergleithcu-godaddy
Copy link

This will definitely help some of our tooling! Great contribution @dclayton-godaddy!

@arothian
Copy link
Contributor

arothian commented May 9, 2022

Thanks for the contribution @dclayton-godaddy . Can you take a look at the rubocop failure and if possible sign the commit(s) - https://docs.github.com/articles/about-gpg/?

@dclayton-godaddy
Copy link
Contributor Author

Thanks for the contribution @dclayton-godaddy . Can you take a look at the rubocop failure and if possible sign the commit(s) - https://docs.github.com/articles/about-gpg/?

sure. Thanks

@dclayton-godaddy
Copy link
Contributor Author

dclayton-godaddy commented May 11, 2022

@arothian rubocop issues have been addressed. Thank you for reviewing this change.

@arothian arothian merged commit 97717cb into stelligent:master May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Locate *Rule.rb in subdirectories
3 participants