Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore-fatal is ignoring normal errors as well #555

Closed
rbalman opened this issue Jun 3, 2021 · 3 comments · Fixed by #556
Closed

ignore-fatal is ignoring normal errors as well #555

rbalman opened this issue Jun 3, 2021 · 3 comments · Fixed by #556
Labels
bug

Comments

@rbalman
Copy link

rbalman commented Jun 3, 2021

Summary
I wanted to ignore non-cloudformation/fatal CloudFormation templates using --ignore-fatal but it is ignoring normal errors as well. Am I missing something here or this is the expected behavior. Please find the screenshots below for further context

Screenshots

  • cfn_nag_scan --input-path service.yaml

Screen Shot 2021-06-03 at 16 11 13

  • cfn_nag_scan --input-path service.yaml --ignore-fatal

Screen Shot 2021-06-03 at 16 12 14
@arothian
Copy link
Contributor

arothian commented Jun 3, 2021

Hi @BalmanRawat , thanks for the report. I agree, it looks like this is removing normal failure results as well. I'll see if we can fix this up.

@arothian arothian added the bug label Jun 3, 2021
arothian added a commit to arothian/cfn_nag that referenced this issue Jun 14, 2021
@arothian
Only filter out fatal errors rather than actual violations
9036574 
Fixes stelligent#555
@arothian arothian mentioned this issue Jun 14, 2021
Merged
@arothian
Copy link
Contributor

@BalmanRawat , if you are able, can you try using the proposed fix in #556 and verify that this resolves your issue?

arothian pushed a commit that referenced this issue Jun 15, 2021
Only filter out fatal errors rather than actual violations (#556)
6eaefdd 
* Only filter out fatal errors rather than actual violations
Fixes #555

* Add tests
@rbalman
Copy link
Author

rbalman commented Jun 16, 2021

Thank you @arothian that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only filter out fatal errors rather than actual violations arothian/cfn_nag
2 participants
@arothian @rbalman