Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECR Repository ScanOnPush Rule Issue #533

Closed
tabdunabi opened this issue Mar 10, 2021 · 1 comment
Closed

ECR Repository ScanOnPush Rule Issue #533

tabdunabi opened this issue Mar 10, 2021 · 1 comment

Comments

@tabdunabi
Copy link

CloudFormation ECR scanOnPush property has changed to ScanOnPush.

References to the changes:
CloudFormation
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ecr-repository.html

CDK AWS-ECR
https://github.com/aws/aws-cdk/blob/278fba5df4a3d785e49bdb57ccf88fd34bacacbb/packages/%40aws-cdk/aws-ecr/lib/repository.ts#L453

Issue
cfn_nag ScanOnPush rule is still checking for scanOnPush
https://github.com/stelligent/cfn_nag/blob/master/lib/cfn-nag/custom_rules/ECRRepositoryScanOnPushRule.rb#L23

A warning is thrown by the rule even if the scan is enabled using the new property name.

pethers added a commit to pethers/cfn_nag that referenced this issue Mar 10, 2021
@pethers
Copy link
Contributor

pethers commented Mar 10, 2021

Thanks for reporting this, have created a PR fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants