Support closures as values for ::set()
#1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to `Memoize::set()` with a `Closure` as a value, resolving it when retrieving from memoization. If the key being retrieved is not itself a Closure, we will resolve the closures recursively from the key downwards. Because `wp_cache_set()` should not store closures, when using the `WpCacheDriver`, any value that is set as a `Closure` will be stored in memory until the Closure is resolved.
There was a problem hiding this comment.
Oh interesting! You took it a slightly different way than I'd meant, which is fine! I originally meant that the function was called upon setting, so the driver doesn't matter. What you've done here is even more clever and it effectively makes a dynamic cached value, as the closure is called upon retrieval.
Honestly, I'm trying to decide if this is extremely clever or a caching anti-pattern. 🤔
This is based on some great recommendations from @defunctl and allows the library to be much more versatile - particularly in projects where Dependency Injection Containers are in use.
Implementing a better OOP structure
|
@JasonTheAdams - tbh, resolving on set would be waaaay simpler and I think I see where you are going with it being a potential anti-pattern. I could see how a result could become unpredictable later based on the moment of resolution. |
|
I went ahead and went the resolve-on-set route for simplification's sake. |
defunctl
added a commit
that referenced
this pull request
Mar 21, 2025
…ntracts\DriverInterface) is implicitly nullable via default value null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to
Memoize::set()with aClosureas a value, resolving it before setting in the cache.Documentation Updates:
README.md: Updated to include a table of contents and examples using the newMemoizerclass instead of the deprecatedMemoizeclass. [1] [2] [3] [4]Codebase Simplification:
src/Memoize/Config.php: Removed theConfigclass in favor of dependency injection for setting drivers and namespaces.src/Memoize/Contracts/DriverInterface.php: Renamed and updated the namespace for consistency.src/Memoize/Contracts/MemoizerInterface.php: Renamed and updated the namespace for consistency. [1] [2]New Features:
src/Memoize/Drivers/MemoryDriver.php: Modified to support closures as cache values, resolving them before storing. [1] [2]src/Memoize/Memoizer.php: Introduced a newMemoizerclass implementingMemoizerInterface, replacing the staticMemoizeclass.Testing Enhancements:
tests/unit/ClosureTest.php: Added new tests to ensure that closures are correctly resolved and stored in the cache.