fullhistory: index fee-bump transactions by both hashes#862
Merged
Conversation
tamirms
force-pushed
the
fullhistory-feebump-inner-hash
branch
2 times, most recently
from
July 16, 2026 15:04
4bb8c20 to
81a9669
Compare
tamirms
marked this pull request as ready for review
July 16, 2026 15:04
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
tamirms
force-pushed
the
fullhistory-feebump-inner-hash
branch
from
July 16, 2026 15:51
81a9669 to
b79c5e8
Compare
karthikiyer56
approved these changes
Jul 16, 2026
tamirms
force-pushed
the
fullhistory-feebump-inner-hash
branch
from
July 16, 2026 22:01
b79c5e8 to
0b1b982
Compare
The v1 RPC stores getTransaction lookup entries for both a fee-bump's hashes (outer and inner); full-history indexed only the outer, so getTransaction(innerHash) regressed to not-found. Both txhash writers now emit one entry per hash — two for a fee-bump — using the inner hash the SDK's extraction walk exposes from the result pair it already visits. The read path needs no change: LedgerTransactionViewByHash resolves either hash since the same SDK change. Requires the go-stellar-sdk fee-bump inner-hash extractors (stellar/go-stellar-sdk#5964), pinned by the go.mod bump. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
tamirms
force-pushed
the
fullhistory-feebump-inner-hash
branch
from
July 16, 2026 22:02
0b1b982 to
24fd5c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
getTransaction(innerHash)for a fee-bump transaction currently returns not-found from the full-history index: both txhash writers key only the outer (result-pair) hash, while the SQLite path stores lookup entries for both hashes (cmd/stellar-rpc/internal/db/transaction.go), so this is a behavioral regression against the API being replaced.This change indexes both hashes. The rule lives once in the txhash package (
EntryHashes: the transaction hash, plus a fee-bump's inner hash), and the hot writer and the cold.binwriter both derive their entries from it, so the two tiers always index the same hash set. The read path needs no change: the SDK'sLedgerTransactionViewByHashresolves either hash since stellar/go-stellar-sdk#5964, so the fetch-and-verify step confirms inner-hash candidates natively.Depends on
stellar/go-stellar-sdk#5964 (merged), which exposes the inner hash on the extraction walk;
go.modpins its pseudo-version.Tests
TestTxhashColdWriter_FeeBumpBothHashescovers the cold writer end to end (both prefixes land in the.bin, mapped to the same seq), and the shared-walk byte-identity guard's reference contract now includes inner-hash entries. Hot-side matching is covered by the SDK's own tests; an e2e fee-bump case through the daemon can follow separately.🤖 Generated with Claude Code