-
Notifications
You must be signed in to change notification settings - Fork 48
e2e tests: use system test callable workflow #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
approved these changes
Oct 13, 2025
Member
leighmcculloch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏻
3cc39fe to
e3530f2
Compare
… will just reference local docker repo for image when forked pr
…allable workflow ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Changed e2e test to use new system test callable pipeline this pipeline leverages image caching from the quickstart callable pipeline and new system-test caching where possible as it depends on the component versions specified. the caching has potential to reduce total time to build the stack for same component versions and run tests.
the last CI run for e2e.yml on this pr which had been run a couple times back to back with same component versions had the caches populated and the completion time for complete build and test execution was about 14 minutes.
Why
Reduce docker image build times, lower test build/setup times.
Known limitations
the gh repo limit on cache size is 10GB, the images being cached are competing for that size with any other CI steps that may be using caching also. evictions are possible, at which point cache misses are likely which requires quickstart or system-test images to be rebuilt again.