Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the specification for muxed accounts in CAP-64. #1635

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Clarify the specification for muxed accounts in CAP-64. #1635

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c7764a
Clarify the specification for muxed accounts in CAP-64.
dmkozh Jan 28, 2025
db9334f
Merge branch 'master' into memo_cap_muxed_acc
dmkozh Jan 29, 2025
a6756b9
Merge branch 'master' into memo_cap_muxed_acc
dmkozh Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions core/cap-0064.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,15 @@ A new type of of address credentials is introduced for `SorobanAuthorizationEntr

The first version of the credentials will still be supported by the protocol. It can be considered to be semantically equivalent to `SOROBAN_CREDENTIALS_ADDRESS_V2` with `txMemo` set to `MEMO_NONE` (i.e. it may only pass authorization check when the transaction memo is `MEMO_NONE`).

#### Muxed accounts restrictions

In order to avoid confusion between memos and muxed source accounts, transactions that contain both of:

- Muxed transaction source account and/or muxed operation source account
- At least one Soroban authorization entry with credentials that are not set to `SOROBAN_CREDENTIALS_SOURCE_ACCOUNT`

are considered invalid and thus they won't be ever included into ledger.

## Design Rationale

The design is simply the minimal necessary set of changes that allows for signing transaction memos. We had to come up with the new XDR structures because the initial versions did not have any extension points. In order to simplify potential future changes, the extension point has been introduced as well.
Expand Down