Skip to content

Conversation

@Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Dec 3, 2025

Closes #2077.

This clarifies the format of a topic filter and introduces an example using the new ** topic syntax. Even though the filters were already defined, they weren't being rendered in the generated docs. Unfortunately another suggestion isn't possible:

Also, change the array[array] to be more descriptive, something like array[array[SegmentMatcher]].

Because types must be OpenRPC primitive types.

@stellar-jenkins
Copy link

1 similar comment
@stellar-jenkins
Copy link

Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this. One ask and one question.

@stellar-jenkins
Copy link

2 similar comments
@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@urvisavla
Copy link
Contributor

Even though the filters were already defined, they weren't being rendered in the generated docs.

I previously highlighted this exact issue when working on the getevents documentation but it wasn't addressed at the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getEvents topics parameter documentation is ambiguous about array structure

5 participants