-
Notifications
You must be signed in to change notification settings - Fork 229
Improve getEvents documentation surrounding filters
#2084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Preview is available here: |
1 similar comment
|
Preview is available here: |
leighmcculloch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this. One ask and one question.
0a72ebe to
34cebbb
Compare
|
Preview is available here: |
2 similar comments
|
Preview is available here: |
|
Preview is available here: |
I previously highlighted this exact issue when working on the getevents documentation but it wasn't addressed at the time. |
Closes #2077.
This clarifies the format of a topic filter and introduces an example using the new
**topic syntax. Even though the filters were already defined, they weren't being rendered in the generated docs. Unfortunately another suggestion isn't possible:Because
types must be OpenRPC primitive types.