Skip to content

Replace legacy Wallets Kit v1 references in current tutorials #2609

Description

@kalepail

Finding

Two current Docs tutorial surfaces still teach the legacy Wallets Kit v1 package
or API. The English Example Application tutorial installs
@creit.tech/stellar-wallets-kit and includes that legacy scope in its Vite SSR
configuration. The Spanish dapp-frontend translation goes further: it installs
and imports the legacy scope and uses new StellarWalletsKit(...) with
allowAllModules().

The current maintained package is the JSR v2 package
@creit-tech/stellar-wallets-kit (latest 2.5.0). Its current initialization
guidance uses static StellarWalletsKit.init(...) with defaultModules() or
explicitly selected modules. The English dapp-frontend source no longer has a
Wallets Kit example, so the Spanish page is also an untranslated obsolete
section rather than a current English counterpart.

Evidence

Live source re-check on 2026-07-14:

The Wallet Integration page at
https://developers.stellar.org/docs/tools/developer-tools/wallets was separately
checked. It only links to the maintained Kit site and contains no package or
API example; it is deliberately excluded from this finding.

Additional recorded evidence:

  • re-verified 2026-07-14: docs/build/apps/example-application-tutorial/overview.mdx installs the legacy dotted npm package @creit.tech/stellar-wallets-kit (line 199) and lists it in Vite ssr.noExternal (line 254)
  • re-verified 2026-07-14: i18n/es/docusaurus-plugin-content-docs/current/build/apps/dapp-frontend.mdx installs and imports @creit.tech/stellar-wallets-kit, then constructs StellarWalletsKit with allowAllModules (lines 240-266)
  • re-verified 2026-07-14: the English docs/build/apps/dapp-frontend.mdx has no @Creit, allowAllModules, or StellarWalletsKit reference; the former tools/developer-tools/wallets page is link-out only and is not evidence for this finding
  • current maintainer sources: JSR lists @creit-tech/stellar-wallets-kit 2.5.0 as latest (published 2026-06-29), and the current kit README/init guide uses static StellarWalletsKit.init with defaultModules

Recommendation

Update the Example Application tutorial's dependency and Vite configuration to
the current supported Wallets Kit path, and either remove the obsolete Spanish
Wallets Kit section or translate a current v2 example. A retained example should
use the JSR v2 package and static initialization with defaultModules() or
explicit module selection; if either tutorial must remain a v1 historical
example, label it clearly as legacy and pin that version rather than presenting
it as current integration guidance.

Source Record

This was found by the downstream Raven eval/improvements loop and recorded as sd-035 (stellar-docs, discovered 2026-07-11).

Public source record: improvements/stellar-docs/sd-035-wallets-kit-jsr-package-api-drift.md

Immutable source snapshot: b9098a92cab9

Resolution Handoff

When a fix is deployed, please link the resolving issue or PR to the source record above and notify Raven through:

https://github.com/kalepail/stellar-raven/issues/new?template=upstream-improvement-ready.yml&title=%5Bupstream-ready%5D%20sd-035%3A%20

Include the finding id, resolving issue/PR, deployed version or timestamp, and the smallest live recheck. Raven independently verifies the upstream surface before changing the finding to fixed-upstream; issue closure or a merged PR alone is not treated as proof. After a distinct reviewer repeats the live check, the active finding is retired to Raven's resolved ledger while the immutable snapshot remains available.

Activity

  1. added
    ravenissues discovered by Stellar Raven QA passes
    on Jul 14, 2026
  2. kalepail commented on Jul 15, 2026

    @kalepail
    ContributorAuthor

    Fresh Raven re-check on 2026-07-15 narrows this issue: the former Spanish i18n/es/.../dapp-frontend.mdx path is no longer present on main, so that translation residual is resolved by removal. The English Example Application tutorial still installs @creit.tech/stellar-wallets-kit and retains that scope in ssr.noExternal (docs/build/apps/example-application-tutorial/overview.mdx, current lines 199 and 254). Remaining requested action is English-only: update or explicitly pin/label that example.

  3. ElliotFriend commented on Jul 21, 2026

    @ElliotFriend
    Contributor

    Shipped a docs-side stopgap in #2659: pinned the tutorial's Wallets Kit install to @^1 so it stops breaking against the v1 companion app.

    Keeping this open for the durable fix — migrating both this tutorial and stellar/basic-payment-app to the Kit v2 API (StellarWalletsKit.init / defaultModules) in lockstep, which is the cross-repo work.

    One correction for the record: the npm scope is not legacy-v1-only — v2.5.0 also publishes to @creit.tech, which is exactly why the unpinned install broke.

  4. self-assigned this
    on Jul 21, 2026
  5. kalepail commented on Jul 27, 2026

    @kalepail
    ContributorAuthor

    You're right, and our issue was wrong on that point. We re-checked the npm registry: @creit.tech/stellar-wallets-kit has dist-tag latest = 2.5.0 (published 2026-06-29), so the dotted npm scope is emphatically not v1-only and "legacy scope" was the wrong diagnosis. The actual defect is the one you identified — an unpinned install resolving to v2 against tutorial code written for the v1 constructor API.

    We've corrected our record and the matching record we filed against the dapp skill, so neither now describes this as a scope problem.

    The @^1 pin in #2659 looks like the right interim state. Agreed the durable fix is migrating this tutorial and stellar/basic-payment-app to StellarWalletsKit.init / defaultModules in lockstep — happy to re-verify once that lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

dev-relravenissues discovered by Stellar Raven QA passes

Type

No type

Projects

  • Status
    No status

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions