Skip to content

Conversation

Copy link

Copilot AI commented Dec 18, 2025

CI currently only builds with tests enabled, allowing code with test-only dependencies to pass validation and break Jenkins production builds configured with --disable-tests.

Changes

  • Added build-without-tests job that builds with --disable-tests using GCC compiler with both current and next protocols (using matrix strategy)
  • Updated complete job to require the new build job before marking CI as successful
  • Fixed bug in ci-build.sh where --disable-tests flag was not being passed to the configure script. The script now properly adds --disable-tests to config_flags following the same pattern as DISABLE_POSTGRES.

The new job follows the same structure as existing build-linux jobs. With the ci-build.sh fix, the --disable-tests flag is now correctly passed to the configure script, which properly disables building tests via the AM_CONDITIONAL(BUILD_TESTS) check.

Original prompt

This section details on the original issue you should resolve

<issue_title>Github CI validation doesn't build a version with --disable-tests</issue_title>
<issue_description>Github CI validation doesn't build a version with --disable-tests, which can leads to us merging in a change that only works as a test build, and then fails to compile in Jenkins. We should add a step that just builds core configured with --disable-tests.</issue_description>

<agent_instructions>ci-build.sh already has support for --disable-tests, so you just need to figure out how to use that.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits December 18, 2025 19:37
Co-authored-by: sisuresh <5050166+sisuresh@users.noreply.github.com>
Co-authored-by: sisuresh <5050166+sisuresh@users.noreply.github.com>
Copilot AI changed the title [WIP] Add build step for CI with --disable-tests Add --disable-tests build validation to CI Dec 18, 2025
Copilot AI requested a review from sisuresh December 18, 2025 19:41
@sisuresh
Copy link
Contributor

@copilot looks like there's an existing bug in ci-build.sh where --disable-tests isn't added to config_flags. Look at DISABLE_POSTGRES as an example of how to fix this.

Co-authored-by: sisuresh <5050166+sisuresh@users.noreply.github.com>
Copy link
Author

Copilot AI commented Dec 18, 2025

@copilot looks like there's an existing bug in ci-build.sh where --disable-tests isn't added to config_flags. Look at DISABLE_POSTGRES as an example of how to fix this.

Fixed in commit afc2c9c. Added DISABLE_TESTS variable and included it in config_flags, following the same pattern as DISABLE_POSTGRES.

Copilot AI changed the title Add --disable-tests build validation to CI Add --disable-tests build validation to CI and fix ci-build.sh bug Dec 18, 2025
@sisuresh
Copy link
Contributor

@copilot can you add a matrix to run this for both current and next?

Co-authored-by: sisuresh <5050166+sisuresh@users.noreply.github.com>
Copy link
Author

Copilot AI commented Dec 18, 2025

@copilot can you add a matrix to run this for both current and next?

Added in commit 607568b. The build-without-tests job now uses a matrix to run for both current and next protocols, following the same pattern as build-linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Github CI validation doesn't build a version with --disable-tests

2 participants