-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add --disable-tests build validation to CI and fix ci-build.sh bug #5079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: sisuresh <5050166+sisuresh@users.noreply.github.com>
Co-authored-by: sisuresh <5050166+sisuresh@users.noreply.github.com>
|
@copilot looks like there's an existing bug in ci-build.sh where --disable-tests isn't added to |
Co-authored-by: sisuresh <5050166+sisuresh@users.noreply.github.com>
Fixed in commit afc2c9c. Added |
|
@copilot can you add a matrix to run this for both current and next? |
Co-authored-by: sisuresh <5050166+sisuresh@users.noreply.github.com>
CI currently only builds with tests enabled, allowing code with test-only dependencies to pass validation and break Jenkins production builds configured with
--disable-tests.Changes
build-without-testsjob that builds with--disable-testsusing GCC compiler with both current and next protocols (using matrix strategy)completejob to require the new build job before marking CI as successful--disable-testsflag was not being passed to the configure script. The script now properly adds--disable-teststoconfig_flagsfollowing the same pattern asDISABLE_POSTGRES.The new job follows the same structure as existing
build-linuxjobs. With the ci-build.sh fix, the--disable-testsflag is now correctly passed to the configure script, which properly disables building tests via theAM_CONDITIONAL(BUILD_TESTS)check.Original prompt
--disable-tests#5078✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.