-
Notifications
You must be signed in to change notification settings - Fork 116
CI: upgrade workflows to use macos-15(*) rather than macos-13 #2276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
leighmcculloch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments. Some are out of scope of this PR but we should follow up.
…chitecture, where needed
… and from `ubuntu-jammy-8-cores-arm64` to `ubuntu-24.04-arm`
leighmcculloch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, although you might want to test the macos and arm builds on the pull request temporarily before merging and finding that they might fail on the push event.
…latest`, and from `ubuntu-jammy-8-cores-arm64` to `ubuntu-24.04-arm`" This reverts commit 79ecbc7.
since it offers better support for nested virtualization. This change is made for the bindings-ts.yml, ledger-emulator.yml, and rpc-tests.yml workflows.
…able the respective linux counterparts. The goal is to test the macos runner
35f4db4 to
ea04e71
Compare
…e on pull requests
… to a large one. In RPC Tests, remove the thread limit for ubuntu
…t execute on pull requests" This reverts commit 43cd776.
What
Upgrade workflows to use
macos-15-*rather thanmacos-13Why
Notes on Runner Compatibility
After extensive testing across macOS runner types:
-largeis usually more stable.I couldn't make the ledger-emulator.yml workflow succeed for macos despite many attempts, so it was temporarily disabled, to be re-added in #2299.