Add ledger entry fetch implementation
#2012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethengelman
force-pushed
the
ledger-entry-get
branch
from
8efe856 to
26e3d38
Compare
…eyAccount We were previously checking to see if asset, offer or data-name were also passed in. If not, the LedgerKeyAccount of the given account was added to the list of keys. However, there is an edge case, that if the user passes in 'xlm' as the asset, the entries was returning empty because there is not an xlm trustline so no key was passed in. As a solution, this PR always include the LedgerKeyAccount in the list of keys, so the LedgerEntryAccount is always returned when --account is passed in as an arg
elizabethengelman
force-pushed
the
ledger-entry-get
branch
from
b92041b to
398d112
Compare
elizabethengelman
force-pushed
the
ledger-entry-get
branch
from
82221c6 to
8d3bfaf
Compare
Co-authored-by: Leigh <351529+leighmcculloch@users.noreply.github.com>
elizabethengelman
force-pushed
the
ledger-entry-get
branch
from
5e2826a to
3f3fde4
Compare
elizabethengelman
force-pushed
the
ledger-entry-get
branch
from
e0aac28 to
231cfc6
Compare
Collaborator
|
the currently failing bindings typescript test should be fixed once #2268 is merged in |
elizabethengelman
added a commit
that referenced
this pull request
Nov 14, 2025
### What this pr is based off of #2012 closes #2273 Updates the `ledger entry fetch` command to allow for returning the contract instance ledger entry by adding an `--instance` option which will include the contract instance ledger entry to the list of keys being fetched. `cargo run ledger entry fetch contract-data --contract hello-world --network local --instance` ### Why This way we are able to more easily fetch a contract wasm hash based on it's contract id/alias. ### Known limitations [TODO or N/A] --------- Co-authored-by: Gleb <gleb@stellar.org> Co-authored-by: Jane Wang <jane.wang@stellar.org> Co-authored-by: Leigh <351529+leighmcculloch@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds
ledger entry getimplementation that allows to fetch ledger entries. Implements all of the supported ledger entry typesstellar ledger entry fetch account <ACCOUNT>stellar ledger entry fetch contract <CONTRACT>stellar ledger entry fetch config <ID>stellar ledger entry fetch claimable-balance <ID>stellar ledger entry fetch liquidity-pool <ID>stellar ledger entry fetch wasm <HASH>Why
#1916
Known limitations
Most of the command variations have not been tested !