Switch some auth errors from Internal to InvalidInput.
#976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These actually can be caused by invalid user input and are not a sign of implementation issue (which we use internal errors for). The reason is that we convert the whole user-provided auth tree to the context for custom auth, without sanitizing it.
sisuresh
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Switch some auth errors from
InternaltoInvalidInput.Why
These actually can be caused by invalid user input and are not a sign of implementation issue (which we use internal errors for). The reason is that we convert the whole user-provided auth tree to the context for custom auth, without sanitizing it.
Known limitations
We don't perform this validation check for classic account auth. While this is a minor inconsistency, I don't think it's worth spending CPU time on it - the invalid entries will just not be matched to anything and there aren't potential problems due to that (whereas in case of custom account authentication providing invalid context might result in incorrect logic).