Charge write fees for expiration entry bumps. #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We charge these as a part of the rent fee, so it's effectively an additional flat component of the final rent cost. It's not going to be explicitly exposed or limited.
sisuresh
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Charge write fees for expiration entry bumps.
We charge these as a part of the rent fee, so it's effectively an additional flat component of the final rent cost. It's not going to be explicitly exposed or limited.
Why
Rent bumps are not completely free, so fee model needs to reflect that. Also this discourages doing extremely short-termed bumps and thus should reduce the ledger load a bit.
Known limitations
N/A