Run tests after push in local ci workflow #793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
changed the base branch from
main
to
add-continue-on-error-test-config
sagpatil
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Extract test job into separate reusable workflow file. Run tests after pushing images instead of as part of build workflow.
Why
In PRs in this repo it is helpful if images are pushed regardless of whether they pass tests or not. This is actually how the workflow behaved prior to the refacctor in #778, but when I did the refactor I wanted the initial refactor to be simpler. This is particularly helpful as we add things like nightly builds to the main branch and on a schedule. Those nightly images need pushing regardless of whether their tests pass and it's more convenient if they push immediately rather than having to wait for a test run to complete. This should be safe to push before test on main because by the time a change makes it to main it has already passed all tests on the pull request.
The build.yml file is intended to be used externally too where tests can run as part of the build, and that's why tests can still be triggered from within the build.yml.
This is a little more complicated than I'd like it to be because of the two ways to use build.yml. I think it might make sense to consider in a follow up further refactoring the entry point of the third party uses of the workflow into another workflow that calls build and test workflows. But I'd like to do that separately.
Merging
This change is intended to merge to
mainafter #792.