Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effects typing fixes #947

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Effects typing fixes #947

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c986c84
improve effect typing
eumemic Apr 28, 2024
6fa7e1f
use a default for backwards compatibility
eumemic Apr 28, 2024
f11f7c7
fix whitespace
eumemic Apr 28, 2024
a5cf166
fix whitespace
eumemic Apr 28, 2024
7b9f526
make AccountDebited an OfferAsset
eumemic Apr 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
make AccountDebited an OfferAsset
  • Loading branch information
@eumemic
eumemic committed Apr 28, 2024
commit 7b9f526713dcb33624fec1f9bc85ac0571635267
2 changes: 1 addition & 1 deletion src/horizon/types/effects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export interface AccountCredited extends BaseEffectRecord<'account_credited'>, O
type_i: EffectType.account_credited;
amount: string;
}
export interface AccountDebited extends BaseEffectRecord<'account_debited'> {
export interface AccountDebited extends BaseEffectRecord<'account_debited'>, OfferAsset {
type_i: EffectType.account_debited;
amount: string;
}
Expand Down