Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify possible trade_type filter values in README. #706

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Sep 8, 2021

The changelog should be comprehensive!

Copy link
Contributor

@marcelosalloum marcelosalloum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM! I'm not sure why the integration tests are failing though.

@Shaptic
Copy link
Contributor Author

Shaptic commented Sep 9, 2021

@marcelosalloum something changed in the /operations and /effects endpoints on the APIary server, so it was serving invalid JSON. This run should pass 👍.

@Shaptic Shaptic merged commit 45bb962 into master Sep 10, 2021
@Shaptic Shaptic deleted the fix-readme branch September 10, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants