Regenerate XDR with latest Protocol 23 version #800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +8.76 kB (+0.26%) Total Size: 3.32 MB
|
Change the commit hash to the right sha of stellar/stellar-xdr. Add any new filenames (if needed: here Stellar-exporter.x for Galexie). Run `make reset-xdr` from the project root.
Shaptic
force-pushed
the
bump-xdr
branch
2 times, most recently
from
53feed7 to
0d719c4
Compare
* Move `xdr.Operation` into a hidden namespace to avoid conflicts with the
SDK's `Operation`.
* Minimize the diff by running `sed -ie s/\"/\'/g types/{curr,next}.d.ts`
(because the generator uses a different prettier config--this could
probably be fixed in the generator itself, but this is easy enough
for now).
* Add workarounds:
- `type Hash = Opaque[];` is a necessary alias that doesn't get gen'd
- `Hyper`, `UnsignedHyper`, and `ScSpecEventV0` need their signatures
fixed because it should take a proper `Array` instead of a naked `[]`
(enforced by `yarn lint`).
- Some constants aren't generated correctly, ref. the linked issue
Account for generator bugs: constants that aren't present
* This accounts for any fields that encountered a rename as part of the new XDR version. In this case, `readBytes` was renamed to `diskReadBytes` because it's measured differently as a result of Core's state living in memory rather than on disk in most cases. * It also accounts for the unused extension point actually having a name now, so `xdr.ExtensionPoint` needs to use the structure- specific `xdr.SorobanTransactionDataExt`, instead.
|
the separate commits for each step are great. Do you think it's worth including link to this pr as example of those steps in the existing README#xdr-update, it doesn't mention this type of guidance. |
sreuland
approved these changes
May 19, 2025
|
Yep good call @sreuland, I jotted that down as a TODO but might as well throw it in. I think your ✔️ is good enough - there's no major code changes here and CI passes. |
Shaptic
added a commit
that referenced
this pull request
Jun 18, 2025
* 1. Run the generator:
Change the commit hash to the right sha of stellar/stellar-xdr.
Add any new filenames (if needed: here Stellar-exporter.x for Galexie).
Run `make reset-xdr` from the project root.
* 2. Post-generation fixups to work around bugs or project-specific stuff:
* Move `xdr.Operation` into a hidden namespace to avoid conflicts with the
SDK's `Operation`.
* Minimize the diff by running `sed -ie s/\"/\'/g types/{curr,next}.d.ts`
(because the generator uses a different prettier config--this could
probably be fixed in the generator itself, but this is easy enough
for now).
* Add workarounds:
- `type Hash = Opaque[];` is a necessary alias that doesn't get gen'd
- `Hyper`, `UnsignedHyper`, and `ScSpecEventV0` need their signatures
fixed because it should take a proper `Array` instead of a naked `[]`
(enforced by `yarn lint`).
- Some constants aren't generated correctly, ref. the linked issue
* 3. Accommodate XDR additions or renames:
* This accounts for any fields that encountered a rename as part
of the new XDR version. In this case, `readBytes` was renamed to
`diskReadBytes` because it's measured differently as a result of
Core's state living in memory rather than on disk in most cases.
* It also accounts for the unused extension point actually having
a name now, so `xdr.ExtensionPoint` needs to use the structure-
specific `xdr.SorobanTransactionDataExt`, instead.
* Add docs to README for completeness
6 tasks
Shaptic
added a commit
that referenced
this pull request
Jun 25, 2025
* Add strkey support for liquidity pools and claimable balances (#799) * Regenerate XDR with latest Protocol 23 version (#800) * Migrate cryptographic libraries to use modern @noble/curves. (#802) * Add support for encoding `Address` to/from new `StrKey`s (#801) * Allow specifying mixed types for vectors in `nativeToScVal` (#803) * Prepare v14.0.0-rc.1, Protocol 23 for release (#804)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corresponds to stellar/stellar-xdr@4b7a2ef.
This is a great example of the step-by-step process to update XDR with each commit message describing the detailed separate steps of the process.