Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a type comparison bug in authorization helpers. #701

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Oct 9, 2023

For some reason, !== on the object does not work in some envs.
Note that it works fine in the unit tests.
This is a faster check, anyway.

Reported by @tyvdh on Discord here.

@Shaptic Shaptic added the bug label Oct 9, 2023
@Shaptic Shaptic added this to the Soroban Stable P20 Release milestone Oct 9, 2023
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Size Change: +10 B (0%)

Total Size: 3.16 MB

Filename Size Change
dist/stellar-base.js 2.32 MB -2 B (0%)
dist/stellar-base.min.js 843 kB +12 B (0%)

compressed-size-action

Copy link
Contributor

@kalepail kalepail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Shaptic Shaptic merged commit 54abb1b into master Oct 9, 2023
4 checks passed
@Shaptic Shaptic deleted the auth-typefix branch October 9, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants