Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encodes the correct field name in the RevokeLiquidityPoolSponsorship type #522

Merged
merged 3 commits into from
Apr 11, 2022
Merged

Encodes the correct field name in the RevokeLiquidityPoolSponsorship type #522

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66020ba
Likely a copy-paste error resulting in the wrong field name on the iface
Shaptic Apr 6, 2022
dd8e990
Add CHANGELOG entry
Shaptic Apr 6, 2022
9bdc9b1
Merge branch 'master' into fix-field-name
Shaptic Apr 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

### Fix

- Correct a TypeScript definition on the `RevokeLiquidityPoolSponsorship` operation ([#522](https://github.com/stellar/js-stellar-base/pull/522)).

- Resolves a bug that incorrectly sorted `Asset`s with mixed-case asset codes (it preferred lowercase codes incorrectly) ([#516](https://github.com/stellar/js-stellar-base/pull/516)).

- Update developer dependencies:
Expand Down
2 changes: 1 addition & 1 deletion types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,7 +746,7 @@ export namespace Operation {
): xdr.Operation<RevokeClaimableBalanceSponsorship>;

interface RevokeLiquidityPoolSponsorship extends BaseOperation<OperationType.RevokeSponsorship> {
balanceId: string;
liquidityPoolId: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeahh.. unfortunately the entire set of operations doesn't have tests. This is a one-off fix but I have a long list of how we can get better TypeScript testing in this library (and better API testing in general...). Unfortunately, it's a behemoth of a task.

}
function revokeLiquidityPoolSponsorship(
options: OperationOptions.RevokeLiquidityPoolSponsorship
Expand Down