Move MuxedAccount to a separate file and drop the createSubaccount method.
#487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
force-pushed
the
separate-muxed-accounts
branch
from
d4dcdd0
to
dc6d934
Compare
leighmcculloch
approved these changes
Jan 11, 2022
Shaptic
force-pushed
the
separate-muxed-accounts
branch
from
7dfab19
to
abefef9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #433 by removing the
createSubaccountmethod entirely fromAccount,MuxedAccount, and their shared interface. This allows the two objects to be in separate files.See #433 for discussion.