Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce claimable balance IDs to be 72-byte strings. #390

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Enforce claimable balance IDs to be 72-byte strings. #390

merged 1 commit into from
Mar 19, 2021

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Feb 24, 2021

Closes #388.

@Shaptic Shaptic requested a review from a team February 24, 2021 17:39
@Shaptic Shaptic self-assigned this Feb 24, 2021
@Shaptic Shaptic merged commit 8eeeac6 into master Mar 19, 2021
@Shaptic Shaptic deleted the cb-validation branch March 19, 2021 19:04
Shaptic added a commit that referenced this pull request Aug 3, 2021
@Shaptic
Enforce claimable balance IDs to be 72-byte strings (#390)
6e17925 
This closes #388, allowing SDK users to "fail fast" when crafting a bad claimable balance rather than encountering the error much later down the line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartekn bartekn bartekn approved these changes

Assignees

@Shaptic Shaptic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check balanceID bytes in claim claimable balance op
2 participants
@Shaptic @bartekn