Skip to content

manageBuyOffer inconsistent parameter naming #200

Open

Description

In js-stellar-base, manageBuyOffer amount parameter has been named buyAmount.

However, in the stellar.org guide it is referenced as amount. Horizon uses amount parameter as well when returning the operation record.

Hence, I assume js-stellar-base should use amount instead of buyAmount for a matter of consistency, which is also more consistent with manageSellOffer & passiveSellOffer amount parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Hacktoberfestsuggested issues for Hacktoberfestbug

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions