Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow zero fees #871

Merged
merged 6 commits into from
May 9, 2023
Merged

Allow zero fees #871

merged 6 commits into from
May 9, 2023

Conversation

Ifropc
Copy link
Contributor

@Ifropc Ifropc commented May 8, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    paymentservice.stellar, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.

What

ANCHOR-273 Allow zero fees in patch transaction

Why

Currently exception is throw if fee is zero

Known limitations

N/A

@Ifropc Ifropc requested a review from JakeUrban May 8, 2023 20:37
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

1 similar comment
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

This reverts commit 625d042.
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@Ifropc Ifropc merged commit 63a6a39 into legacy/main-1.2 May 9, 2023
@Ifropc Ifropc deleted the ANCHOR-273 branch May 9, 2023 22:40
@Ifropc Ifropc mentioned this pull request May 9, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants