Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Anchor-149] Update DETELE endpoint to take customer types into account #734

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

Ifropc
Copy link
Contributor

@Ifropc Ifropc commented Feb 7, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    paymentservice.stellar, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.

What

Follow-up of #721 : DELETE endpoint was not updated there

Why

Make changes consistent

Known limitations

N/A

Copy link
Contributor

@JakeUrban JakeUrban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for getting on this quickly!

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

Copy link
Collaborator

@lijamie98 lijamie98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you also port the changes to develop?

@stellar-jenkins
Copy link

Reference Server Preview is available here:
https://anchor-ref-pr734.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr734.previews.kube001.services.stellar-ops.com/

@Ifropc Ifropc mentioned this pull request Feb 7, 2023
4 tasks
@Ifropc Ifropc merged commit 4a806f2 into main Feb 7, 2023
@Ifropc Ifropc deleted the anchor-149 branch February 7, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants