Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add offer liabilities #531

Merged
merged 4 commits into from
Aug 2, 2018
Merged

Add offer liabilities #531

merged 4 commits into from
Aug 2, 2018

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Jul 9, 2018

Adds offer liabilities to Account and Trustline objects. More info: stellar/stellar-core#1718

This is a breaking change, release with other Protocol V10 updates. No longer a breaking change after c60f888.

TODO:

nullstyle
nullstyle previously approved these changes Jul 31, 2018
Copy link
Contributor

@nullstyle nullstyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks bartek

@bartekn
Copy link
Contributor Author

bartekn commented Aug 2, 2018

This change actually goes with v10 update (was planned for v11). Woking on updating tests and making it working with pre-v10 core db schema.

Copy link
Contributor

@nullstyle nullstyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bartekn bartekn merged commit 0e29fa7 into master Aug 2, 2018
@bartekn bartekn deleted the offers-liabilities branch August 2, 2018 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants