[CHORE] adds platform to events emitted

[aristidesstaffieri]

Closes #2199

Adds platform field to metrics, in order to be able to key events by platform.

[CassioMG]

Nice

[CassioMG]

I've just realized this looks like a duplicate of this other issue? #2393

[CassioMG]

@aristidesstaffieri can we also assign a Platform user property in addition to the event property?

On mobile we are setting both so we can easily filter users as well

[aristidesstaffieri]

@aristidesstaffieri can we also assign a Platform user property in addition to the event property?

On mobile we are setting both so we can easily filter users as well

@CassioMG it looks like on mobile, we set a random ID for the user field in the same way the extension does today. Am I missing this somewhere else or are you suggesting we update both projects to use the real pub key?
https://github.com/stellar/freighter-mobile/blob/14f91c4e82d310f4d4db8812e461e450a31b0e10/src/services/analytics/user.ts#L37

[CassioMG]

@aristidesstaffieri can we also assign a Platform user property in addition to the event property?
On mobile we are setting both so we can easily filter users as well

@CassioMG it looks like on mobile, we set a random ID for the user field in the same way the extension does today. Am I missing this somewhere else or are you suggesting we update both projects to use the real pub key? https://github.com/stellar/freighter-mobile/blob/14f91c4e82d310f4d4db8812e461e450a31b0e10/src/services/analytics/user.ts#L37

@aristidesstaffieri it looks like this PR only adds the platform property to events. So in addition to adding to events I'm suggesting also adding it as a user property, which would allow us to easily filter user profiles on Amplitude by platform. Does that make sense?

See sample below:

[aristidesstaffieri]

@aristidesstaffieri can we also assign a Platform user property in addition to the event property?
On mobile we are setting both so we can easily filter users as well

@CassioMG it looks like on mobile, we set a random ID for the user field in the same way the extension does today. Am I missing this somewhere else or are you suggesting we update both projects to use the real pub key? https://github.com/stellar/freighter-mobile/blob/14f91c4e82d310f4d4db8812e461e450a31b0e10/src/services/analytics/user.ts#L37

@aristidesstaffieri it looks like this PR only adds the platform property to events. So in addition to adding to events I'm suggesting also adding it as a user property, which would allow us to easily filter user profiles on Amplitude by platform. Does that make sense?

See sample below:

ok got it, it looks like mobile uses the sdk here in order to automatically add these properties. We should add separate task for this, the extension does not use the sdk at all right now or identify users so its a bigger line of work and unrelated to separating events by platform.

I made this one to track that refactor -> #2464

[CassioMG]

ok got it, it looks like mobile uses the sdk here in order to automatically add these properties. We should add separate task for this, the extension does not use the sdk at all right now or identify users so its a bigger line of work and unrelated to separating events by platform.

I made this one to track that refactor -> #2464

Ah ok, got it that makes sense to me. Thanks for creating the ticket 👍