Only import alloc if alloc feature enabled#4
Merged
leighmcculloch merged 1 commit intomainfrom Dec 1, 2023
Merged
Conversation
graydon
approved these changes
Dec 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Only import alloc if alloc feature enabled.
Why
Importing alloc all the time causes the global allocator to be need to be set. But the intent of the alloc feature is to make the lib compatible with builds that don't have an allocator, of which the soroban-sdk is one.
We don't actually use escape-bytes in the soroban-sdk when building for wasm, but through a series of unfortunate events escape-bytes is still getting included because we use it for
Debugimpls in stellar-xdr that get compiled for all targets.