v2: Last 10 ledgers info #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview deployed to development environment: https://dashboard.prototypes.kube001.services.stellar-ops.com |
Closed
piyalbasu
reviewed
Feb 15, 2022
| @@ -102,6 +102,11 @@ export const startLedgerStreamingAction = createAsyncThunk< | |||
| .stream({ | |||
| onmessage: (ledger: LedgerRecord) => { | |||
| const { lastLedgerRecords } = ledgersSelector(getState()); | |||
|
|
|||
| if (!lastLedgerRecords[0]) { | |||
There was a problem hiding this comment.
just curious: is it possible for this array to have a length but have no record (or null) at index 0? I'm assuming no
There was a problem hiding this comment.
mainly wondering why you chose to check for this instead of lastLedgerRecords.length
There was a problem hiding this comment.
Good point, we could be checking just for the array length here, but I went with the lastLedgerRecords[0] because it's used below in lastLedgerRecords[0].closedAt. Do you think it would more clear to check for the array length?
piyalbasu
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LedgerClosedTimeto a separate component