fix: error on unknown flags in call command#35
Open
beverm2391 wants to merge 1 commit intosteipete:mainfrom
Open
fix: error on unknown flags in call command#35beverm2391 wants to merge 1 commit intosteipete:mainfrom
beverm2391 wants to merge 1 commit intosteipete:mainfrom
Conversation
Previously, unknown flags like `--source` passed to the call command were
silently treated as positional arguments and mapped to tool parameters via
hydratePositionalArguments. This caused confusing behavior where:
mcporter call server.tool --source import
Would result in `{"includeStarted": "import"}` being sent to the tool,
causing validation errors that were hard to debug.
Now unknown `--` prefixed flags in the call command throw a helpful error
with suggestions for how to pass tool arguments correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Unknown flags passed to the
callcommand were silently treated as positional arguments and mapped to tool parameters viahydratePositionalArguments. This caused confusing behavior where:Would result in
{"includeStarted": "import"}being sent to the tool (mappingimportto the first tool parameter), causing validation errors that were hard to debug.Solution
Added a check in
parseCallArgumentsto detect unknown--prefixed flags before they get pushed to the positional array. Now it throws a helpfulCliUsageErrorwith suggestions:Testing
key=valuestyle arguments work--args '{...}'style arguments work