Fix erroneous SetCapture after COptionMenu::onMouseDown #303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #302
COptionMenu::onMouseDown
returnskMouseDownEventHandledButDontNeedMovedOrUpEvents
Prior to release 4.11,
Win32Frame::proc
would not callSetCapture
in response:vstgui/vstgui/lib/platform/win32/win32frame.cpp
Lines 778 to 779 in 6431f63
In 4.11 and onwards, only
event.consumed
is being checked, sokMouseDownEventHandledButDontNeedMovedOrUpEvents
results in a call toSetCapture
which leads to the behavious described in #302:vstgui/vstgui/lib/platform/win32/win32frame.cpp
Lines 833 to 834 in addf12b
This PR adds a
!event.ignoreFollowUpMoveAndUpEvents ()
check so thatSetCapture
is not called in response tokMouseDownEventHandledButDontNeedMovedOrUpEvents
.