Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leak in CNewFileSelector::run (CallbackFunc&& callback) #286

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Fix leak in CNewFileSelector::run (CallbackFunc&& callback) #286

merged 1 commit into from
Mar 1, 2023

Conversation

nickdowell
Copy link
Contributor

CNewFileSelector objects were being leaked when using run (CallbackFunc&&) because of a retain cycle; the lambda assigned to impl->doneCallback added a SharedPointer to this that would never be freed.

Verified by adding a breakpoint on CNewFileSelector::~CNewFileSelector()

@scheffle scheffle merged commit 9486910 into steinbergmedia:master Mar 1, 2023
@nickdowell nickdowell deleted the fix-file-selector-memory-leak branch March 1, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickdowell @scheffle