Skip to content

Commit

Permalink
[NFC][NVPTX] Remove dead comment and commented code
Browse files Browse the repository at this point in the history
A confusing comment after the last return statement in
`NVPTXAsmPrinter::doFinalization` referred to a preprocessor macro
(NVISA) that has never existed since the NVPTX backend has been a part
of upstream llvm - as far as the pickaxe will tell me anyway. Thus I've
removed it.

Differential Revision: https://reviews.llvm.org/D140399
  • Loading branch information
ldrumm committed Dec 23, 2022
1 parent 391cb54 commit 22bf4a7
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -913,15 +913,6 @@ bool NVPTXAsmPrinter::doFinalization(Module &M) {
TS->outputDwarfFileDirectives();

return ret;

//bool Result = AsmPrinter::doFinalization(M);
// Instead of calling the parents doFinalization, we may
// clone parents doFinalization and customize here.
// Currently, we if NVISA out the EmitGlobals() in
// parent's doFinalization, which is too intrusive.
//
// Same for the doInitialization.
//return Result;
}

// This function emits appropriate linkage directives for
Expand Down

0 comments on commit 22bf4a7

Please sign in to comment.