Run Tests on PHP 8.4 (#55)

stefanzweifel · Nov 13, 2024 · 38fcaf2 · 38fcaf2
1 parent ac8936e
commit 38fcaf2
Show file tree

Hide file tree

Showing 26 changed files with 700 additions and 797 deletions.
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -9,7 +9,7 @@ jobs:
       fail-fast: true
       matrix:
         os: [ubuntu-latest]
-        php: [8.2, 8.3]
+        php: [8.2, 8.3, 8.4]
 
     name: P${{ matrix.php }} - ${{ matrix.os }}
 

diff --git a/app/Actions/AddReleaseNotesToChangelogAction.php b/app/Actions/AddReleaseNotesToChangelogAction.php
@@ -20,8 +20,7 @@ public function __construct(
         private readonly FindSecondLevelHeadingWithText $findSecondLevelHeadingWithText,
         private readonly PlaceReleaseNotesBelowUnreleasedHeadingAction $addNewReleaseNotesWithUnreleasedHeadingToChangelog,
         private readonly PlaceReleaseNotesAtTheTopAction $addNewReleaseToChangelog
-    ) {
-    }
+    ) {}
 
     /**
      * @throws Throwable

diff --git a/app/Actions/ExtractPermalinkFragmentFromHeadingAction.php b/app/Actions/ExtractPermalinkFragmentFromHeadingAction.php
@@ -18,9 +18,7 @@
 
 class ExtractPermalinkFragmentFromHeadingAction
 {
-    public function __construct(private readonly GitHubActionsOutput $gitHubActionsOutput)
-    {
-    }
+    public function __construct(private readonly GitHubActionsOutput $gitHubActionsOutput) {}
 
     public function execute(Heading $releaseHeading): string
     {
@@ -62,8 +60,8 @@ protected function prepareCommonmarkEnvironment(): Environment
         ];
 
         $environment = new Environment($config);
-        $environment->addExtension(new CommonMarkCoreExtension());
-        $environment->addExtension(new HeadingPermalinkExtension());
+        $environment->addExtension(new CommonMarkCoreExtension);
+        $environment->addExtension(new HeadingPermalinkExtension);
 
         return $environment;
     }
@@ -74,12 +72,12 @@ protected function prepareCommonmarkEnvironment(): Environment
      */
     protected function attachPermalinkToHeading(Heading $releaseHeading, Environment $environment): Document
     {
-        $document = new Document();
+        $document = new Document;
         $document->appendChild($releaseHeading);
 
         $documentParsedEvent = new DocumentParsedEvent($document);
 
-        $processor = (new HeadingPermalinkProcessor());
+        $processor = (new HeadingPermalinkProcessor);
         $processor->setEnvironment($environment);
         $processor->__invoke($documentParsedEvent);
 
@@ -92,7 +90,7 @@ protected function attachPermalinkToHeading(Heading $releaseHeading, Environment
      */
     protected function extractLinkFragmentFromRenderedHtml(string $html): ?string
     {
-        $domDocument = new DOMDocument();
+        $domDocument = new DOMDocument;
         $domDocument->loadHTML($html);
 
         /** @var \DOMAttr $hrefAttribute */

diff --git a/app/Actions/InsertReleaseNotesInChangelogAction.php b/app/Actions/InsertReleaseNotesInChangelogAction.php
@@ -10,9 +10,7 @@
 
 class InsertReleaseNotesInChangelogAction
 {
-    public function __construct(private readonly PrepareReleaseNotesAction $prepareReleaseNotes)
-    {
-    }
+    public function __construct(private readonly PrepareReleaseNotesAction $prepareReleaseNotes) {}
 
     /**
      * @throws ReleaseNotesCanNotBeplacedException
@@ -40,6 +38,6 @@ public function execute(Document $changelog, string $releaseNotes, Heading $newR
 
         // If the CHANGELOG doesn't have any children, we currently don't insert the release notes.
         // An exception is thrown and an error message is displayed to the user.
-        throw new ReleaseNotesCanNotBeplacedException();
+        throw new ReleaseNotesCanNotBeplacedException;
     }
 }
diff --git a/app/Actions/ParseAndLinkifyGitHubUsernamesAction.php b/app/Actions/ParseAndLinkifyGitHubUsernamesAction.php
@@ -30,8 +30,8 @@ public function execute(?string $releaseNotes): ?string
         ];
 
         $environment = new Environment($config);
-        $environment->addExtension(new MarkdownRendererExtension());
-        $environment->addExtension(new MentionExtension());
+        $environment->addExtension(new MarkdownRendererExtension);
+        $environment->addExtension(new MentionExtension);
 
         $parser = new CommonmarkMarkdownParser($environment);
         $renderer = new CommonmarkRenderer($environment);

diff --git a/app/Actions/PlaceReleaseNotesAtTheTopAction.php b/app/Actions/PlaceReleaseNotesAtTheTopAction.php
@@ -25,8 +25,7 @@ public function __construct(
         private readonly CreateNewReleaseHeadingWithCompareUrl $createNewReleaseHeadingWithCompareUrl,
         private readonly GenerateCompareUrl $generateCompareUrl,
         private readonly GitHubActionsOutput $gitHubActionsOutput,
-    ) {
-    }
+    ) {}
 
     /**
      * @throws Throwable

diff --git a/app/Actions/PlaceReleaseNotesBelowUnreleasedHeadingAction.php b/app/Actions/PlaceReleaseNotesBelowUnreleasedHeadingAction.php
@@ -22,8 +22,7 @@ public function __construct(
         private readonly CreateNewReleaseHeadingWithCompareUrl $createNewReleaseHeading,
         private readonly GitHubActionsOutput $gitHubActionsOutput,
         private readonly InsertReleaseNotesInChangelogAction $insertReleaseNotesInChangelogAction
-    ) {
-    }
+    ) {}
 
     /**
      * @throws Throwable

diff --git a/app/Actions/PrepareReleaseNotesAction.php b/app/Actions/PrepareReleaseNotesAction.php
@@ -10,9 +10,7 @@
 
 class PrepareReleaseNotesAction
 {
-    public function __construct(private readonly Markdown $markdown, private readonly ShiftHeadingLevelInDocumentAction $shiftHeadingLevelInDocument)
-    {
-    }
+    public function __construct(private readonly Markdown $markdown, private readonly ShiftHeadingLevelInDocumentAction $shiftHeadingLevelInDocument) {}
 
     public function execute(string $releaseNotes, Heading $newReleaseHeading): Document
     {

diff --git a/app/Actions/ShiftHeadingLevelInDocumentAction.php b/app/Actions/ShiftHeadingLevelInDocumentAction.php
@@ -14,7 +14,7 @@ class ShiftHeadingLevelInDocumentAction
 
     public function execute(Document $document, int $baseHeadingLevel): Document
     {
-        $headings = (new Query())
+        $headings = (new Query)
             ->where(Query::type(Heading::class))
             ->findAll($document);
 

diff --git a/app/CreateNewReleaseHeading.php b/app/CreateNewReleaseHeading.php
@@ -10,9 +10,7 @@
 
 class CreateNewReleaseHeading
 {
-    public function __construct(private readonly ExtractPermalinkFragmentFromHeadingAction $extractPermalinkFragmentFromHeading)
-    {
-    }
+    public function __construct(private readonly ExtractPermalinkFragmentFromHeadingAction $extractPermalinkFragmentFromHeading) {}
 
     public function create(string $text, string $releaseDate, bool $hideDate = false): Heading
     {

diff --git a/app/CreateNewReleaseHeadingWithCompareUrl.php b/app/CreateNewReleaseHeadingWithCompareUrl.php
@@ -16,8 +16,7 @@ public function __construct(
         private readonly GenerateCompareUrl $generateCompareUrl,
         private readonly GitHubActionsOutput $gitHubActionsOutput,
         private readonly ExtractPermalinkFragmentFromHeadingAction $extractPermalinkFragmentFromHeading
-    ) {
-    }
+    ) {}
 
     public function create(string $repositoryUrl, string $previousVersion, string $latestVersion, string $headingText, string $releaseDate, bool $hideDate = false): Heading
     {

diff --git a/app/Providers/AppServiceProvider.php b/app/Providers/AppServiceProvider.php
@@ -16,7 +16,7 @@ class AppServiceProvider extends ServiceProvider
      */
     public function boot()
     {
-        $this->app->singleton(GitHubActionsOutput::class, fn () => new GitHubActionsOutput());
+        $this->app->singleton(GitHubActionsOutput::class, fn () => new GitHubActionsOutput);
     }
 
     /**

diff --git a/app/Queries/FindFirstSecondLevelHeading.php b/app/Queries/FindFirstSecondLevelHeading.php
@@ -17,7 +17,7 @@ public function find(Document $document): ?Heading
         /**
          * @phpstan-var Heading|null
          */
-        return (new Query())
+        return (new Query)
             ->where(Query::type(Heading::class))
             ->andWhere(new HeadingLevel(2))
             ->findOne($document);

diff --git a/app/Queries/FindSecondLevelHeadingWithText.php b/app/Queries/FindSecondLevelHeadingWithText.php
@@ -18,7 +18,7 @@ public function find(Document $document, string $previousVersion): ?Heading
         /**
          * @phpstan-var Heading|null
          */
-        return (new Query())
+        return (new Query)
             ->where(Query::type(Heading::class))
             ->andWhere(new HeadingLevel(2))
             ->andWhere(new HeadingText($previousVersion))

diff --git a/app/Queries/FindUnreleasedHeading.php b/app/Queries/FindUnreleasedHeading.php
@@ -20,7 +20,7 @@ public function find(Document $document): ?Heading
         /**
          * @phpstan-var Heading|null
          */
-        return (new Query())
+        return (new Query)
             ->where(Query::type(Heading::class))
             ->andWhere(Query::hasChild(Query::type(Link::class)))
             ->andWhere(Query::hasChild(Query::hasChild(Query::type(Text::class))))

diff --git a/app/QueryExpressions/HeadingLevel.php b/app/QueryExpressions/HeadingLevel.php
@@ -10,9 +10,7 @@
 
 class HeadingLevel implements ExpressionInterface
 {
-    public function __construct(private readonly int $level)
-    {
-    }
+    public function __construct(private readonly int $level) {}
 
     public function __invoke(Node $node): bool
     {

diff --git a/app/QueryExpressions/HeadingText.php b/app/QueryExpressions/HeadingText.php
@@ -11,9 +11,7 @@
 
 class HeadingText implements ExpressionInterface
 {
-    public function __construct(private readonly string $text)
-    {
-    }
+    public function __construct(private readonly string $text) {}
 
     public function __invoke(Node $node): bool
     {

diff --git a/app/Support/Markdown.php b/app/Support/Markdown.php
@@ -12,8 +12,7 @@ class Markdown
     public function __construct(
         private readonly MarkdownParser $markdownParser,
         private readonly MarkdownRenderer $markdownRenderer
-    ) {
-    }
+    ) {}
 
     public function parse(string $markdown): Document
     {

diff --git a/app/Support/MarkdownParser.php b/app/Support/MarkdownParser.php
@@ -15,7 +15,7 @@ class MarkdownParser
 
     public function __construct(Environment $environment)
     {
-        $environment->addExtension(new CommonMarkCoreExtension());
+        $environment->addExtension(new CommonMarkCoreExtension);
         $this->parser = new CommonmarkMarkdownParser($environment);
     }
 

diff --git a/app/Support/MarkdownRenderer.php b/app/Support/MarkdownRenderer.php
@@ -16,7 +16,7 @@ class MarkdownRenderer
 
     public function __construct(Environment $environment)
     {
-        $environment->addExtension(new MarkdownRendererExtension());
+        $environment->addExtension(new MarkdownRendererExtension);
 
         $this->renderer = new CommonmarkRenderer($environment);
     }