Allows #del to receive a Array(RedisValue).
#105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @stefanwille, it seems you hadn't the proper time yet to look into the recent PR's. This one closes the issue 100 and the PR 101 and allows two other projects move forward. Additionally, If I can support you with this shard, let me know. Thanks for the hard work. |
kostya
added a commit
that referenced
this pull request
Jul 5, 2021
|
this is in some way in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for allowing the method
#delto receive anArray(RedisValue)and perform the deletes properly.Issue:
When performing a search with the method
#keys, it returns a list of keys asArray(RedisValue)and when trying to pass the returned array to the method#delit fails.On the issue #100 I mentioned about the changing the return of the methods keys, but at looking into the API of the lib, it did not make sense as the issue was on a private method that required a simple overload and a internal casting of the keys to
Stringas per redis implementation, the keys are binary-safe strings.This PR fixes #100