-
Notifications
You must be signed in to change notification settings - Fork 25
Description
Description
On a fresh clone of this project, a 'build' completes successfully while a 'release' fails
Steps to Reproduce
- clone this repository
- execute
yarnto gather all dependencies - execute:
./node_modules/.bin/sense-go build- the command completes successfully - execute:
./node_modules/.bin/sense-go release- the command fails and the log shows:
[15:17:56] uglify:tmp An error occurred. Use -d to show details
[15:17:56] release An error occurred. Use -d to show details
- execute:
./node_modules/.bin/sense-go release -- the command fails but shows more information on the error
[15:18:10] uglify:tmp An error occurred. Here are the details:
error { uid: 7,
name: 'uglify:tmp',
branch: false,
error:
{ GulpUglifyError: unable to minify JavaScript
Caused by: DefaultsError:beautifyis not a supported option
File: C:\work\sources\forks\sense-export.tmp\initialproperties.js
at createError (C:\work\sources\forks\sense-export\node_modules\gulp-uglify\lib\create-error.js:6:14)
at apply (C:\work\sources\forks\sense-export\node_modules\lodash_apply.js:16:25)
at wrapper (C:\work\sources\forks\sense-export\node_modules\lodash_createCurry.js:41:12)
at C:\work\sources\forks\sense-export\node_modules\gulp-uglify\lib\minify.js:54:15
at DestroyableTransform._transform (C:\work\sources\forks\sense-export\node_modules\gulp-uglify\composer.js:10:23)
at DestroyableTransform.Transform._read (C:\work\sources\forks\sense-export\node_modules\readable-stream\lib_stream_transform.js:159:10)
at DestroyableTransform.Transform._write (C:\work\sources\forks\sense-export\node_modules\readable-stream\lib_stream_transform.js:147:83)
at doWrite (C:\work\sources\forks\sense-export\node_modules\readable-stream\lib_stream_writable.js:338:64)
at writeOrBuffer (C:\work\sources\forks\sense-export\node_modules\readable-stream\lib_stream_writable.js:327:5)
at DestroyableTransform.Writable.write (C:\work\sources\forks\sense-export\node_modules\readable-stream\lib_stream_writable.js:264:11)
at DestroyableTransform.ondata (C:\work\sources\forks\sense-export\node_modules\readable-stream\lib_stream_readable.js:541:20)
at emitOne (events.js:116:13)
... - the stack track continues.
Expected behavior
The build should completes successfully for the 'release' task.
Actual behavior
See section 'Steps to reproduce'.
Environment
- node v8.10.0
- npm 5.6.0
- yarn v1.3.2
Operating system
[x ] Windows
[ ] OSX
[ ] Linux
I added this issue for tracking purpose. The fix is to upgrade the sense-go version that is used by this project. I will submit briefly a pull request for this.