Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for podSecurityContext in helm chart #382

Merged

Conversation

cthtrifork
Copy link
Contributor

I see it is supported in timoni but missing from the helm chart

@@ -107,6 +107,9 @@ serviceAccount:
# set container security context
securityContext: {}

# set pod security context
podSecurityContext: {}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add this to the chart readme in the values table? Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I did not see it wasn't automated. Done!

Copy link
Owner

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @cthtrifork

@stefanprodan stefanprodan merged commit b99bf8c into stefanprodan:master Nov 14, 2024
3 checks passed
@cthtrifork cthtrifork deleted the feature/podSecurityContext branch November 14, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants