Skip to content

Commit

Permalink
Merge pull request #349 from mustafakarci/feature/extraEnv
Browse files Browse the repository at this point in the history
feature(chart): allow extraEnvs to be parst
  • Loading branch information
stefanprodan authored Mar 25, 2024
2 parents 50047da + 36bea81 commit e6d611e
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 0 deletions.
1 change: 1 addition & 0 deletions charts/podinfo/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ The following tables lists the configurable parameters of the podinfo chart and
| `service.grpcService` | `podinfo` | gPRC service name |
| `service.nodePort` | `31198` | NodePort for the HTTP endpoint |
| `h2c.enabled` | `false` | Allow upgrading to h2c (non-TLS version of HTTP/2) |
| `extraEnvs` | `[]` | Extra environment variables for the podinfo container |
| `hpa.enabled` | `false` | Enables the Kubernetes HPA |
| `hpa.maxReplicas` | `10` | Maximum amount of pods |
| `hpa.cpu` | `None` | Target CPU usage per pod |
Expand Down
3 changes: 3 additions & 0 deletions charts/podinfo/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ spec:
- name: PODINFO_BACKEND_URL
value: {{ .Values.backend }}
{{- end }}
{{- if .Values.extraEnvs }}
{{ toYaml .Values.extraEnvs | indent 10 }}
{{- end }}
ports:
- name: http
containerPort: {{ .Values.service.httpPort | default 9898 }}
Expand Down
8 changes: 8 additions & 0 deletions charts/podinfo/values-prod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,14 @@ resources:
cpu: 100m
memory: 64Mi

# Extra environment variables for the podinfo container
extraEnvs: []
# Example on how to configure extraEnvs
# - name: OTEL_EXPORTER_OTLP_TRACES_ENDPOINT
# value: "http://otel:4317"
# - name: MULTIPLE_VALUES
# value: TEST

nodeSelector: {}

tolerations: []
Expand Down
8 changes: 8 additions & 0 deletions charts/podinfo/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,14 @@ resources:
cpu: 1m
memory: 16Mi

# Extra environment variables for the podinfo container
extraEnvs: []
# Example on how to configure extraEnvs
# - name: OTEL_EXPORTER_OTLP_TRACES_ENDPOINT
# value: "http://otel:4317"
# - name: MULTIPLE_VALUES
# value: TEST

nodeSelector: {}

tolerations: []
Expand Down

0 comments on commit e6d611e

Please sign in to comment.