This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
Add support for sourcing chart from head ref when testing pull request #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ranch being tested
- environment variables based support for detecting helm releases where chart source is located in a head repository, and cloning right helm chart version from a head source
stefanprodan
reviewed
Jun 3, 2020
|
Sure, have added documentation for this feature to Readme |
stefanprodan
approved these changes
Jun 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #33 and intended to solve the same problem.
How to clone a right helm chart source in the case when helm chart referenced in a helm release being tested by
hrval-actionis located in the same git repository, wherehrval-actionis run ?In case of pull request, if a pull request base repository branch is referenced in helm release,
hrval-actionmight be executed against invalid version of helm chart source, other than one contained in head repository branch.Algorithm:
HRVAL_BASE_BRANCHandHRVAL_HEAD_BRANCHenvironment variables are set, for each helm chart being tested,hrval-actioncurrently runs and therefspecified equals to value specified inHRVAL_BASE_BRANCHenvironment variableHRVAL_HEAD_BRANCHenvironment variablerefsettingThis patch is non-intrusive, and a pre-patch behavior will be executed in case if
HRVAL_BASE_BRANCHandHRVAL_HEAD_BRANCHvariables are not set.