Skip to content
This repository has been archived by the owner on Feb 1, 2021. It is now read-only.

Add AWS S3 repo support #34

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Add AWS S3 repo support #34

merged 1 commit into from
Apr 29, 2020

Conversation

adampeklay
Copy link
Contributor

@adampeklay adampeklay commented Apr 23, 2020

hrval-action needs aws s3 helm repo support

Purpose

I added a step before "Validate Helm Release from Helm Repo" to install helm s3 plugin but the step "Validate Helm Release from Helm Repo" overwrites my changes, so the main code needs to be updated AFAIK.

Changes:

I'm new to GH actions however I think I did this right. Please feel free to suggest changes or make changes as you see fit to make this work. Changes can be seen in "files changed" tab.

Tests:

I did not test this, I only tested my first approach listed in the purpose section and that failed miserably.

Launch Plan:

code owner merges

@adampeklay
Copy link
Contributor Author

adampeklay commented Apr 23, 2020

putting this PR into draft mode, forgot to add the repo & run repo update

My notes from my step before that didn't end up working out (also realized I setting a env var for region would be cleaner).

      - name: Install Helm S3 plugin, add example-helm-repo
        shell: bash
        run: |
          mkdir ~/.aws
          cat << EOF > ~/.aws/config
          [default]
          region = us-east-1
          EOF
          helm plugin install https://github.com/hypnoglow/helm-s3.git
          helm repo add example-helm-repo s3://example.com/charts
          helm repo update

I'll get around to that soon

@adampeklay adampeklay marked this pull request as draft April 23, 2020 22:51
@adampeklay adampeklay marked this pull request as ready for review April 24, 2020 16:44
@adampeklay
Copy link
Contributor Author

adampeklay commented Apr 24, 2020

@stefanprodan I think we may be good to go now.

Perhaps you want to create a draft GithHub Marketplace listing? I was reading up on how to test GitHub Marketplace listings , I didn't want to try to create a draft of this and accidentally step on anyones toes, so to speak.

If you do not wish to include AWS S3 Helm repo functionality that is OK, I can use my fork of your repo and create a new iteration of this for GitHub Marketplace.. of course giving you proper credit for your work!

Let me know what you think about this please, Thank you!

Copy link
Owner

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @adampeklay can you please squash the commits.

@adampeklay adampeklay marked this pull request as draft April 28, 2020 18:55
Signed-off-by: Adam Peklay <adam@peklay.com>

added s3 repo name and plugin args, updated if statement

readme update

readme update 2

syntax fix, if approved please sqaush commits

readme syntax update, final commit

readme syntax update, final commit

added aws s3 repo support

Signed-off-by: Adam Peklay <adam@peklay.com>

added s3 repo name and plugin args, updated if statement

readme update

readme update 2

syntax fix, if approved please sqaush commits

readme syntax update, final commit

readme syntax update, final commit

readme edit

another readme fix
@adampeklay adampeklay marked this pull request as ready for review April 28, 2020 19:09
@adampeklay
Copy link
Contributor Author

@stefanprodan: Done! Sorry that took a while, I didn't see this until today. Haven't squashed from the command line in a while, had to refresh on that!

@stefanprodan stefanprodan changed the title added aws s3 repo support Add AWS S3 repo support Apr 29, 2020
@stefanprodan stefanprodan merged commit 8b04204 into stefanprodan:master Apr 29, 2020
@adampeklay adampeklay deleted the aws-s3-private-helm-repo-support branch April 29, 2020 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants